Skip to content

Daniel vf/caching and static pages#589

Merged
DanielVF merged 2 commits into
masterfrom
DanielVF/caching-and-static-pages
May 6, 2021
Merged

Daniel vf/caching and static pages#589
DanielVF merged 2 commits into
masterfrom
DanielVF/caching-and-static-pages

Conversation

@DanielVF
Copy link
Copy Markdown
Contributor

@DanielVF DanielVF commented May 6, 2021

  • Don't strip our precompiled pages from the deploy
  • Add cache control headers to allow pages to cached by both GAE and Clouldfront.
  • Allow deploying to staging without a Google Analytics ID

@DanielVF DanielVF requested review from nick and sparrowDom May 6, 2021 16:09
@DanielVF DanielVF requested a review from shahthepro as a code owner May 6, 2021 16:09
Copy link
Copy Markdown
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielVF DanielVF merged commit b2b8ab4 into master May 6, 2021
@DanielVF DanielVF deleted the DanielVF/caching-and-static-pages branch May 6, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants