This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Conversation
shahthepro
approved these changes
Feb 4, 2021
Collaborator
shahthepro
left a comment
shahthepro
left a comment
There was a problem hiding this comment.
Had a quick look, looks good to me. LGTM
| oldCodeError: null, | ||
| newCode: '', | ||
| newCodeError: null, | ||
| modalState: 'OTP' |
Collaborator
There was a problem hiding this comment.
nit: Probably better to put this as an enum
franckc
reviewed
Feb 9, 2021
Contributor
|
Do we have any sort of alerting on T3? It would be nice to have an alert on unusual high volume of 2FA resets... that could indicate a hack. |
Contributor
Author
|
We've got Discord webhooks so I'll add a notification 👍 |
Contributor
ah yes, perfect! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements 2FA reset for T3.
Checklist:
fbtfor translationnpm run translate