fix: remove child process spawn on foreground auto-update restart - #45
Closed
branarakic wants to merge 3 commits into
Closed
fix: remove child process spawn on foreground auto-update restart#45branarakic wants to merge 3 commits into
branarakic wants to merge 3 commits into
Conversation
Under systemd, the foreground daemon spawned a child process then exited, causing systemd to restart the service — resulting in two competing daemon instances. Let systemd handle the restart natively since the releases/current symlink is already swapped. Made-with: Cursor
dkg start -f now runs through a foreground supervisor loop that catches exit code 75 and respawns from releases/current, matching the background supervisor pattern. Ensures auto-update works on edge devices and systems without an external process manager. Made-with: Cursor
Covers exit-code-75 restart, clean exit, crash recovery with counter reset, SIGINT forwarding to child, and spawn error handling. Made-with: Cursor
Contributor
Author
|
V10 Review: LGTM — reviewed in context of V10 spec. Ready to merge. |
Jurij89
approved these changes
Apr 3, 2026
4 tasks
Contributor
Author
|
Superseded — all changes from this PR have been consolidated into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under systemd, the foreground daemon spawned a child process then exited, causing systemd to restart the service — resulting in two competing daemon instances. Let systemd handle the restart natively since the releases/current symlink is already swapped.