Fix gaps in live weather route forecasts#99
Merged
Orinks merged 1 commit intoJul 20, 2026
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
Live route weather could silently omit cities whose observations were still loading or unavailable. The remaining observations sounded like a complete outlook, while those omitted stretches could use simulated fallback weather and produce unreported rain or heavy rain. V could also announce a simulated forecast while the selected live source was merely loading.
This change accounts for each upcoming city in order, identifies loading and unavailable observations, distinguishes live weather changes from simulated fallback changes, and suppresses invented V forecasts while live data is pending.
What players or maintainers will notice
W route weather reports now name cities whose live observations are still loading or unavailable and warn when simulated fallback may apply. On the road, weather-change announcements identify whether the condition is a live observation near a named city or simulated fallback weather. V says live weather is still loading instead of speaking an Ahead forecast before the first observation arrives. These behaviors also apply when Live weather controls calendar is off.
Tests and checks run
Accessibility impact
All changes are spoken-text improvements on existing keyboard-accessible W and V paths. Regression tests capture the exact screen-reader output for partial live route data, live-weather loading, and simulated fallback identification.
Changelog