Skip to content

fix: parent-directory keys, exit sound, and upload overwrite prompt - #144

Merged
Orinks merged 1 commit into
Orinks:devfrom
Nick6489:fix/parent-nav-exit-overwrite
Sep 1, 2026
Merged

fix: parent-directory keys, exit sound, and upload overwrite prompt#144
Orinks merged 1 commit into
Orinks:devfrom
Nick6489:fix/parent-nav-exit-overwrite

Conversation

@Nick6489

@Nick6489 Nick6489 commented Sep 1, 2026

Copy link
Copy Markdown

Summary

  • Backspace, Alt+Left, and Alt+Up in a file pane did nothing. Those keys were bound to the list's own key event, which wxDragon never reports a key code for, so the handler never matched them. They now use the real key-down (and character) events. Ctrl+Up and Ctrl+[ do the same, which is Command+Up and Command+[ on a Mac.
  • The exit sound was started and then the process died, which tears down the audio device mid-chime. Closing now waits for that sound to finish, with a short cap so a hung device cannot trap the app.
  • Uploading always asked whether to replace the remote file, even when nothing of that name was there. The prompt now appears only when the remote listing already has that name, matching downloads.

Test plan

  • cargo test -p portkeydrop-core --lib -- local_files::
  • cargo test -p portkeydrop --lib -- keys:: ids:: view:: file_pane::
  • cargo clippy -p portkeydrop-core -p portkeydrop --all-targets -- -D warnings
  • In a file pane, Backspace / Alt+Left / Alt+Up (Command+Up / Command+[ on a Mac) go to the parent directory; unmodified arrows still move the cursor; those keys still edit text in the path bar
  • Quit with the exit sound enabled and hear it finish before the process goes away
  • Upload a new file with nothing of that name on the server: no replace prompt. Upload the same name again: the prompt appears

Backspace and the usual parent-directory chords did nothing because the list key event never reported which key was pressed. Closing cut off the exit sound. Uploading always asked to replace a file that was not there.
@Orinks
Orinks merged commit e20f509 into Orinks:dev Sep 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants