Skip to content

feature: added argument for CVE list to scan for specific ones in yaml - #201

Merged
SalwaAdlouni merged 11 commits into
mainfrom
feature/add_CVE_list_to_scan_for_flag_arg
Jul 3, 2025
Merged

feature: added argument for CVE list to scan for specific ones in yaml#201
SalwaAdlouni merged 11 commits into
mainfrom
feature/add_CVE_list_to_scan_for_flag_arg

Conversation

@SalwaAdlouni

Copy link
Copy Markdown
Contributor

added arg for CVE_list so a list a CVEs can be added from the CLI when using agent_asteroid, defaults to empty when to flag arg is given, agent_asteroid should scan for all CVEs in that case.

@SalwaAdlouni
SalwaAdlouni requested a review from a team July 1, 2025 16:19
@codecov

codecov Bot commented Jul 1, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 98.03922% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.11%. Comparing base (d3886a7) to head (e0e3f83).

Files with missing lines Patch % Lines
agent/asteroid_agent.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   95.07%   95.11%   +0.04%     
==========================================
  Files         251      251              
  Lines       11366    11412      +46     
==========================================
+ Hits        10806    10855      +49     
+ Misses        560      557       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SalwaAdlouni SalwaAdlouni changed the title feature : added argument for CVE list to scan for specific ones in yaml feature: added argument for CVE list to scan for specific ones in yaml Jul 1, 2025
Comment thread ostorlab.yaml Outdated
@burogurama

Copy link
Copy Markdown
Member

Don't we need to update the agent logic to read the argument and use it accordingly?

@elyousfi5 elyousfi5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add:

  • logic in agent to get the arg and use only specified cves
  • unit tests for the logic

Comment thread ostorlab.yaml Outdated
Comment thread ostorlab.yaml Outdated
Comment thread ostorlab.yaml
Comment thread agent/asteroid_agent.py Outdated
Comment thread agent/asteroid_agent.py Outdated
Comment thread agent/asteroid_agent.py Outdated
Comment thread agent/asteroid_agent.py Outdated
3asm
3asm previously requested changes Jul 2, 2025
Comment thread agent/asteroid_agent.py Outdated
Comment thread agent/asteroid_agent.py Outdated
Comment thread agent/asteroid_agent.py Outdated
Comment thread tests/asteroid_agent_test.py Outdated
Comment thread agent/asteroid_agent.py Outdated
Comment thread tests/asteroid_agent_test.py Outdated
Comment thread tests/asteroid_agent_test.py
Comment thread tests/asteroid_agent_test.py Outdated
Comment thread agent/asteroid_agent.py
Comment thread agent/asteroid_agent.py
Comment thread agent/asteroid_agent.py Outdated
Comment thread agent/asteroid_agent.py Outdated
@SalwaAdlouni
SalwaAdlouni dismissed stale reviews from 3asm and elyousfi5 July 3, 2025 17:45

comments fixed

@SalwaAdlouni
SalwaAdlouni merged commit c45f77b into main Jul 3, 2025
@3asm
3asm deleted the feature/add_CVE_list_to_scan_for_flag_arg branch July 3, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants