fix(select-bound-info): key dropdown items by value, not index#2159
Open
Aias00 wants to merge 1 commit into
Open
fix(select-bound-info): key dropdown items by value, not index#2159Aias00 wants to merge 1 commit into
Aias00 wants to merge 1 commit into
Conversation
selectedList reorders/shrinks as the user picks database → schema →
table, so key={index} reused the wrong DOM nodes. Use item.value.
Fixes OtterMind#2153
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2153
Summary
SelectBoundInfo rendered selectedList with key={index}. The list reorders/shrinks as the user picks database → schema → table, so index-keyed items got reused across different option types, causing React to patch the wrong DOM node. Changed to key={item.value} and removed the now-unused index param.
Verification
Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.