fix(er-position): persist the new position, not the old record#2163
Open
Aias00 wants to merge 1 commit into
Open
fix(er-position): persist the new position, not the old record#2163Aias00 wants to merge 1 commit into
Aias00 wants to merge 1 commit into
Conversation
savePosition found the existing record p (with the old position) and called update(p), discarding param's new position. Copy param's position into p before updating. Fixes OtterMind#2160 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2160
Summary
ERPositionStorage.savePosition found the existing record p (carrying the OLD position) and called update(p), discarding param's new position. The ER diagram layout could never be updated for an existing (dataSourceId, databaseName, schemaName) key. Fixed by copying param's position into p before updating: p.setPosition(param.getPosition()); update(p);.
Verification
Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.