feat(ui): align Community actions with Lucide icons - #2249
Merged
Conversation
Contributor
Author
|
Follow-up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2248
Summary
Replace mixed legacy iconfont and Ant Design glyphs with Lucide icons across affected Community navigation, chat, MySQL account tree, pagination, directional controls, and local SQL file surfaces. Dashboard uses
ChartNoAxesCombined, created from Lucide official node data throughcreateLucideIconbecause the current directlucide-react@0.356.0dependency predates its named export. Main-navigation glyphs use 18px sizing; file-toolbar actions keep stable 24px boxes with 16px glyphs; and the collapsed Community settings trigger centers its existing 24px Logo in the same 34px target as navigation.Project-owned directional actions now use Lucide chevrons, including paired chevrons for pagination boundaries. The local-file tree uses one state-aware action:
ChevronsUpDownexpands directory nodes already loaded in the frontend, whileChevronsDownUpcollapses the tree. It does not recursively fetch unopened directories. Community Web continues to hide the desktop-only Files capability.Affected surfaces
Verification
yarn install --frozen-lockfile- passed; lockfile unchanged.CommunityMainPageDashboard follow-up - passed.yarn test:i18n- passed after updating Spanish and Korean translations and their English source hashes.yarn run lint- passed; ESLint and Stylelint completed with zero warnings.yarn run build:web:community --app_version=0.0.0- passed; related frontend tests passed and Webpack compiled successfully.git diff --check- passed./workspacereturned HTTP 200 and Webpack hot compilation completed. The final follow-up commit changes only i18n source hashes. Automated browser inspection was unavailable, so final visual review remains manual.Risk and compatibility
Reviewer map
chat2db-community-client/src/pages/main/workspace/components/LocalSQLFileTree/index.tsxfor the state-aware expand/collapse action,src/components/Pagination/index.tsxfor boundary navigation,src/components/SQLEditor/editor/MonacoEditor/ContentDiffViewer.tsxfor imperative Lucide SVG rendering, andsrc/pages/main/CommunityMainPage.tsxfor the Dashboard icon mapping and navigation/settings sizing.Contributor declaration
AI assistance: Substantial AI assistance was used to inspect the affected frontend paths, select and apply Lucide icon mappings, implement the loaded-node expand/collapse state, refine icon sizing, run verification, and prepare the Issue and PR. The resulting diff and runtime boundary were reviewed locally.