Skip to content

feat(sql-editor): use table icon for result tabs - #2285

Merged
openai0229 merged 1 commit into
mainfrom
feat/2283-neutral-result-tab-icon
Jul 28, 2026
Merged

feat(sql-editor): use table icon for result tabs#2285
openai0229 merged 1 commit into
mainfrom
feat/2283-neutral-result-tab-icon

Conversation

@openai0229

Copy link
Copy Markdown
Contributor

Related issue

Closes #2283

Summary

Replace the colored execution-status icon on SQL result tabs with the existing neutral table icon. SQL console result tabs only expose tabular results, while failed executions remain in Output, so the icon now communicates the result type instead of redundant status.

Affected surfaces

  • Frontend / Web
  • Backend / API / Storage
  • Database plugin / Driver
  • JCEF / Desktop packaging
  • CI / Build / Release
  • Documentation only

Verification

  • Commands and results:
    • git diff --check - passed.
    • Targeted ESLint for src/blocks/SearchResult/index.tsx and src/blocks/SearchResult/style.ts with --max-warnings=0 - passed using the existing workspace dependencies.
  • Manual verification: Local Community desktop session hot-reloaded the change; result tabs use the neutral table icon and failed execution output remains in the Output tab.
  • UI evidence: N/A - verified in the local desktop session; no screenshot artifact was committed.

Risk and compatibility

  • Public API or stored data: N/A - presentation-only frontend change.
  • Database or driver compatibility: N/A - SQL execution and result data are unchanged.
  • Network, privacy, or security: N/A - no network or data-handling changes.
  • Community / Local / Pro boundary: Community frontend only.
  • Backward compatibility: Existing result tabs keep the same labels, keys, content, and selection behavior.

Reviewer map

  • Start here: chat2db-community-client/src/blocks/SearchResult/index.tsx result-tab prefixIcon.
  • Failure condition: A result tab has no table icon, retains success/failure coloring, or changes result-tab selection behavior.
  • Rollback or disable path: Revert commit 27e05422.

Contributor declaration

  • I linked the Issue that defines this change.
  • I tested the affected behavior and reported the actual results above.
  • I did not include credentials, private data, or generated build output.
  • I disclosed substantial AI assistance below, or this PR contains no substantial AI-generated code.

AI assistance: Codex assisted with the scoped implementation and verification; the maintainer directed the behavior and reviewed the local UI.

@openai0229
openai0229 force-pushed the feat/2283-neutral-result-tab-icon branch from 27e0542 to c574115 Compare July 28, 2026 02:34
@openai0229
openai0229 merged commit 83bd7c1 into main Jul 28, 2026
16 checks passed
@openai0229
openai0229 deleted the feat/2283-neutral-result-tab-icon branch July 28, 2026 02:41
@openai0229 openai0229 moved this from In Review to Done in Chat2DB Community Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat(sql-editor): use a neutral table icon for result tabs

1 participant