fix(gbase8s): colon-separate database in getMetaDataName and guard GBASEDBTSERVER URL append - #2292
Open
HandSonic wants to merge 1 commit into
Open
fix(gbase8s): colon-separate database in getMetaDataName and guard GBASEDBTSERVER URL append#2292HandSonic wants to merge 1 commit into
HandSonic wants to merge 1 commit into
Conversation
…ASEDBTSERVER URL append (code review follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two GBase 8s (Informix-lineage) issues:
GBase8sMetaData.getMetaDataNamequalified names with a dot (database.table). GBase 8s parsesa.basowner.tablein the current database, so database-qualified references resolved against the wrong object. Database qualification requires the Informix-style colon separator (db:table,db:owner.table).GBase8sDBManager.getConnectionappended":GBASEDBTSERVER=<service>"to the sharedConnectInfoURL on every connect, so each reconnect added another segment and the JDBC URL grew without bound.Fix
getMetaDataName: emitdatabase:tablefor 2-part names anddatabase:owner.tablefor 3-part namesgetConnection: appendGBASEDBTSERVER=only when not already present (idempotent)Tests
New
GBase8sMetaDataTest(colon qualification) andGBase8sDBManagerTest(idempotent URL).mvn teston chat2db-community-gbase8s: 6/6 pass.Verified on fork HandSonic#12 (meaningful CI checks green; dependency-review/project-sync jobs are fork-permission noise). Regression tests pass; adversarial review cleared.