fix(mariadb): quote/escape unmapped JDBC values and keep now()/default bare in SQL conversion - #2302
Merged
Merged
Conversation
…t bare in SQL value conversion (code review follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes verified review findings tracked in #2281: (1) convertJDBCValueStrByType fell back to the raw unquoted super.convertJDBCValueByType for factory-unmapped types (VARCHAR/CHAR/INT/DATE/JSON/ENUM/SET), emitting unescaped values like O'Brien into exported INSERTs — now falls back to the Str variant with quoting/escaping; (2) convertSQLValueByType dropped the FUNCTION_SET short-circuit, quoting now()/default as string literals for TIMESTAMP/DATETIME — restored. Regression tests added. Verified on fork HandSonic#4 (CI green).