feat(sql-editor): improve result history controls - #2344
Merged
Conversation
pirulij67-pixel
approved these changes
Jul 28, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2343
Summary
Separate SQL Output retention from result-tab retention and keep retained execution results in one flat tab strip. Add persisted result ordering and
Keep existing resultssettings, stable execution-batch identity, replacement barriers for late Web/Desktop events, and uniform 200 px result tabs with the standard table icon.Harden the execution lifecycle so each editor owns at most one pending or running request, busy submissions reject explicitly, pre-ID Desktop cancellation is reconciled, and synchronous bridge failures cannot leave the editor permanently busy. Centralize result-tab close-shortcut ownership so one
Cmd/Ctrl+Waction closes at most one visible result.Affected surfaces
Verification
yarn lint- passed ESLint and Stylelint with zero warnings.yarn test:result-tab-preferences- passed result preference and close-shortcut ownership contracts.yarn test:execution-console- passed.yarn test:sql-execution-log- passed.yarn test:sql-execution-batch- passed.yarn test:sql-execution-request-tracker- passed.yarn test:sql-execution-stream- passed.yarn test:result-inspector- passed result inspector and tab-selection contracts.yarn tsx src/blocks/SearchResult/components/SQLPreviewExecute/updateSql.test.ts- passed.yarn test:i18n- passed.yarn build:web:community --app_version=5.3.0- passed Community production build.git diff --check- passed.Risk and compatibility
Reviewer map
chat2db-community-client/src/pages/main/workspace/components/SQLExecute/index.tsx, thensrc/service/sqlExecutionBatch.ts,src/blocks/SearchResult/index.tsx, andsrc/hooks/useSqlExecutor.ts.90a883d0; the change has no server schema or stored-data migration.Contributor declaration
AI assistance: Substantial AI assistance was used for implementation, regression-test design, and final code review. The maintainer directed the product behavior and reviewed the UI throughout the implementation.