fix(plugin): harden Windows path boundaries - #55
Open
Mineru98 wants to merge 2 commits into
Open
Conversation
Propagated from the v0.1.15 integration branch so these survive the merge: - test_helper: drive port programs with `erl` directly (not elixir.bat) to avoid the Windows stdout-pipe break; operations travel as a base64 term. - stdio_test: give the timing test's handshake asserts a 15s ceiling to tolerate erl cold start on Windows CI (keeps the 5s delivery SLA). - .gitattributes: eol=lf so CRLF-sensitive fixtures behave on Windows. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mineru98
added a commit
to Mineru98/ourocode
that referenced
this pull request
Jul 21, 2026
The full-suite windows-ci needs code from sibling PRs (path/CRLF/port test fixes live in Ouro-labs#52/Ouro-labs#55), so it cannot pass on this branch alone. Keep it on the v0.1.15 integration branch, where the merged tree is green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Mineru98
added a commit
to Mineru98/ourocode
that referenced
this pull request
Jul 21, 2026
Both this PR and Ouro-labs#55 carry Ourocode.Test.PortPrograms; Ouro-labs#55 rewrote the helpers to spawn `erl` directly (Windows stdout-pipe fix). Match that here so the two copies are byte-identical: the branches then auto-merge with no test_helper.exs conflict, and this PR is Windows-safe on its own. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows path forms can be normalized differently from Unix paths. Without consistent handling, plugin and config paths can look valid while still pointing outside the intended boundary.
Proposed change
Acceptance criteria
Verification
git diff --checkmix format --check-formattedon changed Elixir filesmix test test/ourocode/config/raw_loader_test.exs test/ourocode/plugin/path_policy_test.exs test/ourocode/command/registry/skill_loader_test.exs test/ourocode/mcp/transport/stdio_test.exs test/ourocode/mcp/transport/stdio_cleanup_test.exs test/ourocode/terminal/interview_panel/text_test.exs-> 42 passedCloses #50