Skip to content

Conversation

@Souma-Sumire
Copy link
Collaborator

@Souma-Sumire Souma-Sumire commented Dec 20, 2025

fix #852

@github-actions github-actions bot added raidboss /ui/raidboss module config ui/config, ui/[module]/config needs-review Awaiting review labels Dec 20, 2025
@xiashtra
Copy link
Collaborator

I think this is an indication of a deeper problem which I'd like to look into rather than just hiding: #852 (comment)

@Souma-Sumire
Copy link
Collaborator Author

Souma-Sumire commented Dec 20, 2025

Sure!
If you want, you can close this pr.

@xiashtra
Copy link
Collaborator

Sure! If you want, you can close this pr.

Let's hold this one open for now until we see what can be done.

@Legends0
Copy link
Collaborator

Legends0 commented Dec 20, 2025

The raidboss_config location does seem to be where this is coming from. The trigger is executed with fake data during the build of raidboss data bundle as a "hackily" way to test that the output is valid.

https://github.com/OverlayPlugin/cactbot/blob/6f4ebbab0810ca04a7c255cdfaf2c0da94f88464/ui/raidboss/raidboss_config.ts#L1391C1-L1415C6

So either we go the method of preventing execution of all response triggers, mute the console messaging from them, or move/remove the console.error in response (this seems to be the only one in a response right now?).

@Legends0
Copy link
Collaborator

Some testing I did, preRun seems to get executed as well, but the run does not. I will move the console log to run.

@Legends0
Copy link
Collaborator

#856 alternative fix on just the trigger. This type of fix maybe needs a lint for catching console use in response block given how the current design of validation works.

@xiashtra
Copy link
Collaborator

superseded by #856

@xiashtra xiashtra closed this Dec 21, 2025
@Souma-Sumire Souma-Sumire deleted the config_console branch January 4, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config ui/config, ui/[module]/config needs-review Awaiting review raidboss /ui/raidboss module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spamming of Log Messages

3 participants