raidboss: marble dragon console log in trigger fix for #852

[Legends0]

cactbot tests response's output strings by executing the trigger with fake data which causes the console to log an error.

Fixes #852

[Legends0]

Ah, I missed the console log in pasting

[Souma-Sumire]

I think that if the goal is just to eliminate the warning, changing console.error to throw new Error might be more straightforward?

[Legends0]

I think that if the goal is just to eliminate the warning, changing console.error to throw new Error might be more straightforward?

I was keeping the log line for debugging if the trigger did not output. The return would be sufficient if a log isn't needed. I'm not sure if throwing an error would produce the log line since it doesn't in the config generation. Additionally, the amount of testing I've seen in game so far and it's a matches line probably indicates that logging of the position if invalid is no longer needed.

[Souma-Sumire]

Throwing an error will generate a log.

Removing it is also fine =v=

[valarnin]

It's important to note that popup-text catches the error in OnTrigger, which will not execute other parts of the trigger. It's not a problem with this trigger specifically, as it doesn't have e.g. a run function that needs to do data cleanup or anything, but it's also not a proper catch-all solution.

We also use console.(log|warn|error) in 283 locations across raidboss triggers currently.

[jacob-keller]

I just saw this while executing tests yesterday too. Thanks for fixing it.

[xiashtra]

LGTM. I wonder if we should make a note in the documentation somewhere to avoid console.(log|warn|error) in response blocks, and also valarnin's comment about throwing possibly interrupting data cleanup in a run block.