adding OvMaths::FMatrix4::Rotation and OvMaths::FMatrix4::Rotate#130
adding OvMaths::FMatrix4::Rotation and OvMaths::FMatrix4::Rotate#130adriengivry merged 2 commits intoOverload-Technologies:developfrom kmqwerty:feature/adding_Rotation_and_Rotate
Conversation
| #include "OvMaths/API/export.h" | ||
| #include "OvMaths/FVector3.h" | ||
| #include "OvMaths/FVector4.h" | ||
| #include "OvMaths/FQuaternion.h" |
There was a problem hiding this comment.
If you forward declare FQuaternion because of circular reference, this include should get moved to the .cpp file.
| /** | ||
| * Forward declaration due to circular reference | ||
| */ | ||
| struct FMatrix4; |
There was a problem hiding this comment.
This isn't necessary as FMatrix4. is already included.
It can be either removed, or we can move #include "OvMaths/FMatrix4.h" from this file to the .cpp file.
|
Looks good overall! I've noted a couple of stuff that we should fix. Morehover, in the future, it would be good to forward declare everything that we can in header files, and move all our includes from header to source files. Thanks for your contribution tho, it's greatly appreciated :) |
|
One other thing, this doesn't resolves #92 as this issue requires exposing these new methods to lua. |
…t is not necessary
Contributes to #92