Remove GL calls from anywhere else than OvRendering#131
Merged
adriengivry merged 5 commits intoOverload-Technologies:developfrom Sep 23, 2020
kmqwerty:refactor/Remove_GL_calls
Merged
Remove GL calls from anywhere else than OvRendering#131adriengivry merged 5 commits intoOverload-Technologies:developfrom kmqwerty:refactor/Remove_GL_calls
adriengivry merged 5 commits intoOverload-Technologies:developfrom
kmqwerty:refactor/Remove_GL_calls
Conversation
adriengivry
added
Graphics
adriengivry
reviewed
Sep 22, 2020
adriengivry
reviewed
Sep 22, 2020
Co-authored-by: Adrien GIVRY <adrien@givry.pro>
Co-authored-by: Adrien GIVRY <adrien@givry.pro>
adriengivry
approved these changes
Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #95
glReadPixels and glViewport wrapps into Rendering methods.
glReadPixels function uses "Format" and "Type" so I add EPixelDataFormat and EPixelDataType.
I tried to see if other gl calls existed in other files else than OvRendering but as far as I know, i could not find it.