Skip to content

Reduced standard shader variant count from 256 to 32#556

Merged
adriengivry merged 1 commit intomainfrom
optim/reduced_shader_variant_count
May 23, 2025
Merged

Reduced standard shader variant count from 256 to 32#556
adriengivry merged 1 commit intomainfrom
optim/reduced_shader_variant_count

Conversation

@adriengivry
Copy link
Copy Markdown
Member

@adriengivry adriengivry commented May 23, 2025 •
edited
Loading

Description

  • Reduced standard shader variant count from 256 to 32
  • All functionalities have been kept, but some runtime branches got added (for clipping) where the cost is low enough
  • Added built-in tonemapping (reinhard) to standard shader, so it can be used with gamma correction for UI and debug (no branch, low cost interpolation)
  • Reduced standard shader compilation time by 10X

Related Issue(s)

Fixes #554

Review Guidance

Write here.

Screenshots/GIFs

Write here.

@adriengivry adriengivry self-assigned this May 23, 2025
@adriengivry adriengivry added Optimization Optimization related stuff Graphics Graphical feature labels May 23, 2025
@adriengivry adriengivry marked this pull request as ready for review May 23, 2025 16:30
@adriengivry adriengivry merged commit 6e52731 into main May 23, 2025
1 check passed
@adriengivry adriengivry deleted the optim/reduced_shader_variant_count branch May 23, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@adriengivry adriengivry

Labels

Graphics Graphical feature Optimization Optimization related stuff

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reduce standard shader compilation time

1 participant

@adriengivry