Fix Crash when deleting a folder outside of Overload and trying to expand it afterwards#725#729
Merged
adriengivry merged 7 commits intoOverload-Technologies:mainfrom Apr 18, 2026
Conversation
adriengivry
requested changes
Apr 17, 2026
Member
adriengivry
left a comment
adriengivry
left a comment
There was a problem hiding this comment.
Actually contextual actions on the missing folder cause crash (show in explorer, import here, rename...)
Synyproxy
commented
Apr 17, 2026
Contributor
Author
Synyproxy
left a comment
Synyproxy
left a comment
There was a problem hiding this comment.
this should handle the other asset browser context menu actions on deleted folder
adriengivry
requested changes
Apr 17, 2026
Comment on lines
+295
to
+299
| if (!ValidateFolderPath(filePath)) | ||
| { | ||
| ShowPathDeletedError("Create shader"); | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
ValidateFolderPath could automatically show the error message when it fails.
So we can have something like:
if (!ValidateFolderPath(filePath, "Create shader") return;
Comment on lines
+139
to
+153
| bool ShowPathDeletedError(const std::string& p_actionName) | ||
| { | ||
| if (!std::filesystem::exists(std::filesystem::path(p_actionName))) | ||
| { | ||
| using namespace OvWindowing::Dialogs; | ||
| MessageBox errorMessage( | ||
| "Action failed", | ||
| "Cannot perform this action because the target folder was deleted externally", | ||
| MessageBox::EMessageType::ERROR, | ||
| MessageBox::EButtonLayout::OK | ||
| ); | ||
| return true; | ||
| } | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
Probably doesn't need a return value, and could simply log to the console with OVLOG_ERROR
Contributor
Hi ! |
adriengivry
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes this bug:
Delete a folder outside of Overload, then try expanding the folder in Overload causes crash.
Now expanding the folder shows error message.
Also fixed deleting that folder from the asset browser.
Related Issue(s)
#725
Fixes #725
Review Guidance
When expanding a delete folder, user get's feedback message.
Also fixed deleting that folder from the asset browser
Checklist