fix-missing-reference-asset-display#741
Merged
adriengivry merged 1 commit intoOverload-Technologies:mainfrom Apr 19, 2026
Merged
fix-missing-reference-asset-display#741adriengivry merged 1 commit intoOverload-Technologies:mainfrom
adriengivry merged 1 commit intoOverload-Technologies:mainfrom
Conversation
Contributor
|
Naaaaa |
adriengivry
approved these changes
Apr 19, 2026
Gopmyc
reviewed
Apr 20, 2026
Contributor
There was a problem hiding this comment.
Hey, quick note on your PR :
in GUIDrawer::GetAssetDisplayName, the (Missing Reference) logic looks like it’s placed after a return, so it’s currently unreachable.
I think the fix is just to restructure the function a bit, compute the stem first, then check for existence before the final return.
Also, to stay consistent with CONTRIBUTING.md, make sure to keep braces on if statements (F.4) and avoid one-liner ifs (F.5).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: display "(Missing Reference)" for missing asset references (#739)
Added an asset existence checker callback to the GUIHelpers system.
When an asset reference points to a non-existent file, AssetFields now
display the asset name with "(Missing Reference)" appended, making it
clear that the reference is invalid.
Related Issue(s)
(#739)
Fixes #(issue number)
739
Checklist