Skip to content

fix-missing-reference-asset-display#741

Merged
adriengivry merged 1 commit intoOverload-Technologies:mainfrom
Synyproxy:bugfix-issue-739
Apr 19, 2026
Merged

fix-missing-reference-asset-display#741
adriengivry merged 1 commit intoOverload-Technologies:mainfrom
Synyproxy:bugfix-issue-739

Conversation

@Synyproxy
Copy link
Copy Markdown
Contributor

Description

fix: display "(Missing Reference)" for missing asset references (#739)

Added an asset existence checker callback to the GUIHelpers system.
When an asset reference points to a non-existent file, AssetFields now
display the asset name with "(Missing Reference)" appended, making it
clear that the reference is invalid.

Related Issue(s)

(#739)
Fixes #(issue number)
739

Checklist

  • My code follows the project's code style guidelines
  • When applicable, I have commented my code, particularly in hard-to-understand areas
  • When applicable, I have updated the documentation accordingly
  • My changes don't generate new warnings or errors
  • I have reviewed and take responsibility for all code in this PR (including any AI-assisted contributions)

@Gopmyc
Copy link
Copy Markdown
Contributor

Gopmyc commented Apr 19, 2026

Naaaaa
You submit the PR right when I start working on it 😂

@adriengivry adriengivry merged commit 0a42eee into Overload-Technologies:main Apr 19, 2026
6 checks passed
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, quick note on your PR :
in GUIDrawer::GetAssetDisplayName, the (Missing Reference) logic looks like it’s placed after a return, so it’s currently unreachable.

I think the fix is just to restructure the function a bit, compute the stem first, then check for existence before the final return.

Also, to stay consistent with CONTRIBUTING.md, make sure to keep braces on if statements (F.4) and avoid one-liner ifs (F.5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants