Skip to content

Editor crashes when deleting an already deleted file/folder#83

Merged
adriengivry merged 1 commit intoOverload-Technologies:developfrom
zetsumi:fix/delete_folder
Jun 8, 2020
Merged

Editor crashes when deleting an already deleted file/folder#83
adriengivry merged 1 commit intoOverload-Technologies:developfrom
zetsumi:fix/delete_folder

Conversation

@zetsumi
Copy link
Copy Markdown
Contributor

@zetsumi zetsumi commented Jun 5, 2020

Fixing file/folder suppression from AssetBrowser when this same file/folder has already been deleted using an external tool (Ex: Windows Explorer)

Crash on multi delete folder
@zetsumi zetsumi changed the title WIP Crash Editor on multi deletion folder WIP: Crash Editor on multi deletion folder Jun 5, 2020
@zetsumi zetsumi changed the title WIP: Crash Editor on multi deletion folder Crash Editor on multi deletion folder Jun 5, 2020
@adriengivry
Copy link
Copy Markdown
Member

Just to clarify the issue fixed by this PR:

Overload isn't auto-refreshing its AssetBrowser when a file/folder is added/deleted/renamed externally (With another external file system, such as explorer), thus, when an item is deleted from the disk while being display in AssetBrowser, trying to delete it again from the "not up-to-date" AssetBrowser will cause a crash.

@adriengivry adriengivry added Bug Crash Something that causes a crash Editor Something relative with the editor labels Jun 8, 2020
@adriengivry adriengivry changed the title Crash Editor on multi deletion folder Editor crashes when deleting an already deleted file/folder Jun 8, 2020
@adriengivry adriengivry merged commit cb7997e into Overload-Technologies:develop Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Crash Something that causes a crash Editor Something relative with the editor

Development

Successfully merging this pull request may close these issues.

2 participants