[REFACTOR] Inline PathSegment and expand the Check docstring#571
Open
Seth Fitzsimmons (sethfitz) wants to merge 2 commits into
Open
[REFACTOR] Inline PathSegment and expand the Check docstring#571Seth Fitzsimmons (sethfitz) wants to merge 2 commits into
Seth Fitzsimmons (sethfitz) wants to merge 2 commits into
Conversation
PathSegment named the StructSegment | ArraySegment subset, while FieldSegment names the full StructSegment | ArraySegment | MapSegment set. Side by side, PathSegment read as a misleading middle name for something that excludes MapSegment. It was used at two sites, so inline the union and drop the alias. Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
expr and read_columns are two views of one computation: expr is the single composed Column, read_columns its read-set. The docstring now explains why they are carried separately, since the builder knows the columns as it composes expr and records them rather than recovering them from the finished Column. Signed-off-by: Seth Fitzsimmons <seth@mojodna.net>
🗺️ Schema reference docs preview is live!
Note ♻️ This preview updates automatically with each push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up Victor Schappert (@vcschapp)'s review of #518 (superseded by #569), addressing the two actionable inline comments. The naming and map-generality threads from that review are tracked separately in #570.
PathSegmentalias (StructSegment | ArraySegment) at its two use sites and drop it.FieldSegmentalready names the generalStruct | Array | Mapcase, soPathSegmentwas a misleading middle name for a subset that excludesMapSegment.Checkdocstring to relateexpr(the single composedColumn) andread_columns(its read-set), and to say why they are carried separately.No behavior change. Stacked on
pyspark-expression-codegen(#569); the base retargets tomainwhen #569 merges.Related: #570