Remove invalid "warn" argument passed to tinyobj::loadObject(...) #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed "warn" argument passed to tinyobj::LoadObj(...).
Removed "warn" argument passed to tinyobj::LoadObj(...).
Removed "warn" argument passed to tinyobj::LoadObj(...).
Removed "warn" argument passed to tinyobj::LoadObj(...) from e-book.
Removed "warn" argument passed to tinyobj::LoadObj(...).
Overv
approved these changes
May 11, 2025
Owner
|
Awesome, thank you very much for your contribution :) |
|
May I ask why this patch relies on a 2017 version of tinyObjLoader ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: #404
There is no function in the current implementation of TinyObjLoader which accepts more than one string in its arguments for error logging. Because of this, the unfixed example code causes a compilation failure.
To fix this, I removed the "warn" string passed to the tinyobj::loadObject(...) function, in the example code for chapters 28, 29, and 30; I also updated the code in both languages of the Loading Models chapter.