feat(weight): add fallible constructors and enhance security document…#108
Merged
Conversation
…ation - Introduced `try_with_capacity` and `try_with_capacity` methods for `WeightStore` and `ConcurrentWeightStore`, allowing for non-panicking allocation when capacity is derived from untrusted input. - Added a comprehensive section on security considerations in the module documentation, addressing risks related to hashers, capacity management, and handling sensitive values. - Updated the `clear` method to attribute removed entries to the `removes` metric, ensuring accurate tracking of bulk operations alongside per-entry removals. - Improved documentation for existing constructors to clarify panic behavior on allocator failure. These changes enhance the robustness and security of the weight store implementations, aligning with best practices for handling untrusted input and sensitive data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ation
try_with_capacityandtry_with_capacitymethods forWeightStoreandConcurrentWeightStore, allowing for non-panicking allocation when capacity is derived from untrusted input.clearmethod to attribute removed entries to theremovesmetric, ensuring accurate tracking of bulk operations alongside per-entry removals.These changes enhance the robustness and security of the weight store implementations, aligning with best practices for handling untrusted input and sensitive data.
Description
Related Issue
Fixes #
Type of Change
How Has This Been Tested?
Test environment:
Checklist
cargo fmtandcargo clippycargo test)Screenshots (if applicable)
Additional Notes