fix: give the release workflow a manual retry path - #12
Merged
Conversation
The first run of the new workflow failed at startup, because
release-plz/action was not in this repository's allowed-actions list:
The action release-plz/action@2eb1d8bc... is not allowed in
P4suta/windows-spawn because all actions must be from a repository owned
by P4suta, created by GitHub, or match one of the patterns
The list has been corrected. What the failure exposed is that there was no way
to try again: a run that fails at startup is not retryable, and with `on: push`
alone the only other trigger is a commit landing on main, which goes through a
pull request. A release that fails for a transient or configuration reason
would have needed a no-op commit to retry.
Add workflow_dispatch. It is not a second way to release: release-plz still
publishes only when the manifest version is ahead of the registry, so
dispatching from main when nothing is pending does nothing.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first run of the new release-plz workflow failed at startup:
This repository restricts Actions to an allowlist, and
release-plz/actionwas missing from it — the sibling repositories already have it. The allowlist has been corrected; the entry now sits alongside the existingdtolnay/rust-toolchain,Swatinem/rust-cache,taiki-e/install-action, andrust-lang/crates-io-auth-actionpatterns.What the failure exposed
There was no way to try again. A run that fails at startup is not retryable (
gh run rerunrefuses it), and withon: pushalone the only other trigger is a commit landing onmain— which goes through a pull request. A release that failed for a transient or configuration reason would have needed a no-op commit to retry.workflow_dispatchfixes that. It is not a second way to release: release-plz still publishes only when the manifest version is ahead of the registry, so dispatching frommainwhen nothing is pending does nothing.Merging this also re-triggers the workflow, which verifies the allowlist fix.
🤖 Generated with Claude Code