fix: keep xtask out of the release-plz publish set - #13
Merged
Conversation
release-plz refused to run:
ERROR Package `xtask` has `publish = false` or `publish = []` in the
Cargo.toml, but it has `publish = true` in the release-plz configuration.
`release = false` on the xtask package entry stops release-plz from releasing
it, but the workspace-level `publish = true` still reaches it, and release-plz
treats that disagreement with the manifest as a configuration error rather than
ignoring it. Restate `publish = false` on the package entry.
restart-manager does not hit this because its whole workspace is
`publish = false`; conpty-oxide has no second workspace member at all. This is
the first repository here that both publishes through release-plz and carries
an xtask.
Verified with `release-plz release --dry-run` locally: the configuration now
parses and validates, leaving only the expected "git release not configured"
error from having no token outside CI.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-plz releaserefused to run on the last attempt:release = falseon the xtask package entry stops release-plz from releasing it, but the workspace-levelpublish = truestill reaches it, and release-plz treats that disagreement with the manifest as a configuration error rather than ignoring it. This restatespublish = falseon the package entry.Neither sibling hits this:
restart-manager's whole workspace ispublish = false, andconpty-oxidehas no second workspace member. This is the first repository that both publishes through release-plz and carries an xtask.Verification
Installed
release-plz0.3.160 locally and ranrelease-plz release --dry-run. The configuration now parses and validates — the only remaining error is the expectedgit release not configuredfrom having no token outside CI. Before this change it failed on the xtask conflict.That also gives a way to catch this class of error before pushing, which the previous three attempts on this workflow did not have.
🤖 Generated with Claude Code