-
Notifications
You must be signed in to change notification settings - Fork 81
[21.x] Bump log4j-api to 2.25.0 #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21.x] Bump log4j-api to 2.25.0 #2247
Conversation
Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.24.3 to 2.25.0. https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.25.0 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> (cherry picked from commit b062989)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a routine dependency upgrade, specifically updating the Log4j API to its latest stable version. This ensures the project benefits from the most recent improvements and security fixes provided by the new release.
Highlights
- Dependency Upgrade: Upgraded the
log4j-apidependency from version2.24.3to2.25.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the log4j2.version from 2.24.3 to 2.25.0. A potential breaking change in the new Log4j version related to Spring Boot integration should be considered before merging.
| <!-- Overrides Spring Boot slf4j and log4j2 dependency version --> | ||
| <slf4j.version>2.0.17</slf4j.version> | ||
| <log4j2.version>2.24.3</log4j2.version> | ||
| <log4j2.version>2.25.0</log4j2.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade to Log4j 2.25.0 introduces a potentially breaking change that could affect modules using Spring. According to the Log4j 2.25.0 release notes, the log4j-spring-boot starter no longer includes log4j-web as a transitive dependency. If any part of the application relies on log4j-web for features like automatic Log4j initialization and de-initialization in a servlet container (via Log4jServletContainerInitializer), this dependency will need to be added explicitly to the relevant module's pom.xml to prevent runtime issues.
Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.24.3 to 2.25.0.
https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.25.0
(cherry picked from commit b062989)