Skip to content

Conversation

@jrobichaud
Copy link
Contributor

@jrobichaud jrobichaud commented Jan 17, 2020

This code from

Array *array = new python::Array;

    for (auto i: pvset)
    {
        //ABELL - Leak?
        Array *array = new python::Array;
        array->update(i);
        output.push_back(array);
    }

allocates an array for each pvset but the arrays were were never released. This PR Fixes this by releasing the memory of the c++ arrays used to pass the data to the python binding.

Closes #23

@jrobichaud jrobichaud marked this pull request as ready for review January 17, 2020 21:49
@jrobichaud jrobichaud requested a review from hobu January 19, 2020 01:09
@hobu hobu added this to the 2.3 milestone Jan 20, 2020
@hobu hobu merged commit b048960 into PDAL:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory leak when calling pdal.Pipeline

4 participants