Height Above Ground algorithm #72
Conversation
|
You might want to give them the option to use |
|
Added the |
|
Thank you for adding the function! Exactly what I am looking for, since there seem to be no other tool in QGIS to perform a point cloud normalization. Hope it will be adopted in the next release. |
|
This should go into the next version of QGIS, that is the plan 👍 This is part of the crowdfunding described https://www.lutraconsulting.co.uk/crowdfunding/qgis-3d-for-open-source-digital-twins |
wonder-sk
left a comment
wonder-sk
left a comment
There was a problem hiding this comment.
I think this algorithm will also need to worry about potential artifacts at the edges (just like e.g. density or to_raster) because it needs points from the neighborhood, and that neighborhood may be in some other tile...
src/height_above_ground.cpp
Outdated
| if (!argReplaceZWithHeightAboveGround->set()) | ||
| { | ||
| replaceZWithHeightAboveGround = false; // default | ||
| } | ||
|
|
||
| if (!argNNCount->set()) | ||
| { | ||
| nnCount = 1; // default | ||
| } | ||
|
|
||
| if (!argNNMaxDistance->set()) | ||
| { | ||
| nnMaxDistance = 0; // default | ||
| } |
There was a problem hiding this comment.
aren't these defaults already defined in addArgs() ? do we need this code at all?
| dimensions = pipeline.arrays[0].dtype.names | ||
|
|
||
| # check dimensions | ||
| assert "HeightAboveGround" in dimensions |
There was a problem hiding this comment.
my expectation was that this new dimension would not get saved when replace-z == true (unnecessary duplication)
| src/translate.cpp | ||
| src/utils.cpp | ||
| src/vpc.cpp | ||
| src/height_above_ground.cpp |
There was a problem hiding this comment.
let's keep it here as is, but it would be good to keep the list alphabetically sorted :-)
4 participants
Adds Height above ground algorithm and tests.