[WIP] Helper function to deal with timepoint-specific parameters #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
Next PEtab version 0.0.0a16
|
ping |
|
@elbaraim : ping |
will take care of this now |
…des and update doc
here just making the example work now, deletion of experimentId then in #111
* try new travis login * re-fix and update version * tmp do on test branch * undo tmp changes. new password seems to work. updated to 0.0.0a15 meanwhile, so next version must be 0.0.0a16
* adding main file for visualization * adding file for grouping the data which should be plotted * adding file with plotting routine for distinct cases * added file comments, tidy up the code * fix pep8 * update version * some beauty corrections * now: function which should be used, to plot data * style corrections * new example file * minor edits * add test example for visualization with specification file routine * add typehints * minor corrections * flake8 corrections * update folder structure * minor changes & __init__ * move visualization folder to petab subdir * create viz notebook; tidy up code; fix imports and flake8 * add seaborn as requirement * fix flake8, correct link to benchmarking repo
* adding local files for testing visualization * adding the possibility to plot without visualization file or simulation file * update documentation and tests * add the possibility to group plots via simple lists, if no visualization specification file is around * extend and tidy up the examples accordingly * regroup code into new files, try to have each function smaller and better understandable * update gitignore for macOS * updated tests to capture warnings and exceptions * Delete the check for identical noise before plotting points of a dataset - I can think of many applications, in which I want to plot one dataset in which points with different noise values appear. We should allow this to the user * add the check for NANs in a dataset to avoid plotting empty datasets and cluttering the legend
* added an initial parameter sampling functionality * add tests for startpoint sampling * added documentation for the additional columns intialization and objectivePriorType and Parameters
added 8 commits
October 4, 2019 13:46
…thub.com:ICB-DCM/PEtab into feature_125_flatten_timepoint_specific_overrides
Codecov Report
@@ Coverage Diff @@
## develop #128 +/- ##
===========================================
+ Coverage 68.44% 71.45% +3.01%
===========================================
Files 11 11
Lines 1090 1121 +31
Branches 256 262 +6
===========================================
+ Hits 746 801 +55
+ Misses 307 272 -35
- Partials 37 48 +11
Continue to review full report at Codecov.
|
yannikschaelte
requested changes
Oct 4, 2019
yannikschaelte
requested changes
Oct 5, 2019
yannikschaelte
approved these changes
Oct 8, 2019
| df = petab_problem.measurement_df.loc[ | ||
| (petab_problem.measurement_df['observableId'] == | ||
| df_unique_values.loc[nrow, "observableId"]) | ||
| & (petab_problem.measurement_df['preequilibrationConditionId'] <= |
There was a problem hiding this comment.
now observableId is checked with ==, but why are the others still checked with <=?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125
@elbaraim : your turn to make it pass ;)