Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Sep 21, 2020

No description provided.

dweindl and others added 9 commits July 29, 2020 14:11
* Add issue template for PEtab specification change requests

* Apply suggestions from code review

Co-authored-by: Fabian Fröhlich <fabian@schaluck.com>
* saving visu spec

* unnecessary imports removed


Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
* Error message for missing IDs, with line numbers.
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #468 into master will decrease coverage by 0.07%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
- Coverage   78.02%   77.95%   -0.08%     
==========================================
  Files          22       22              
  Lines        2225     2254      +29     
  Branches      531      540       +9     
==========================================
+ Hits         1736     1757      +21     
- Misses        363      366       +3     
- Partials      126      131       +5     
Impacted Files Coverage Δ
petab/visualize/__init__.py 100.00% <ø> (ø)
petab/visualize/plot_data_and_simulation.py 75.34% <55.55%> (-2.79%) ⬇️
petab/lint.py 77.19% <66.66%> (-0.58%) ⬇️
petab/sbml.py 56.83% <90.00%> (+5.16%) ⬆️
petab/core.py 82.91% <100.00%> (ø)
petab/problem.py 71.36% <100.00%> (-0.50%) ⬇️
petab/version.py 100.00% <100.00%> (ø)
petab/yaml.py 90.76% <100.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768eb5b...0d6ce54. Read the comment docs.

Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dweindl dweindl merged commit 826e7f7 into master Sep 21, 2020
@dweindl dweindl deleted the release_0.1.9 branch September 21, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants