Conversation
Closes #572
dilpath
approved these changes
Dec 11, 2023
Member
dilpath
left a comment
There was a problem hiding this comment.
Looks fine to me.
- could add a URL to the publication, but the DOI suffices
- could add a license, though I guess it's irrelevant for a citation
- I can't see a link to the paper in the README. Could move the "How to cite" section of the docs to the README, or mention the paper in the README somewhere
- Is the "How to cite" section redundant or complementary to this?
Co-authored-by: Dilan Pathirana <59329744+dilpath@users.noreply.github.com>
Member
Author
GitHub automatically converts the doi to an URL, so I think that's fine.
will do.
I think it's good to have it somewhere on the RTD page, but the README itself doesn't really need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #572