Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Mar 20, 2025

So far, when math expressions were parsed, they were evaluated as far as possible. This was not always desirable.

Now, this optional as far as conveniently possible.

Closes #363.

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (101c79c) to head (27a2b28).
Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
petab/v1/math/SympyVisitor.py 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #365      +/-   ##
===========================================
+ Coverage    74.55%   74.57%   +0.02%     
===========================================
  Files           57       57              
  Lines         6075     6080       +5     
  Branches      1057     1058       +1     
===========================================
+ Hits          4529     4534       +5     
  Misses        1141     1141              
  Partials       405      405              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review March 20, 2025 15:07
@dweindl dweindl requested a review from a team as a code owner March 20, 2025 15:07
@dweindl dweindl mentioned this pull request Mar 22, 2025
So far, when math expressions were parsed, they were evaluated as far as possible.
This was not always desirable.

Now, this optional as far as conveniently possible.

Closes PEtab-dev#363.
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dweindl dweindl merged commit 81af370 into PEtab-dev:develop Mar 27, 2025
7 checks passed
@dweindl dweindl deleted the evaluate_gh-363 branch March 27, 2025 18:53
@dweindl dweindl linked an issue Mar 28, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add evaluate: bool argument to math parser

3 participants