Skip to content

Fix return type in petab.v2.calculate #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2025
Merged

Fix return type in petab.v2.calculate #464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions petab/v2/calculate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,14 +308,14 @@ def calculate_chi2(
chi2s = [
calculate_chi2_for_table_from_residuals(df) for df in residual_dfs
]
return sum(chi2s)
return float(sum(chi2s))


def calculate_chi2_for_table_from_residuals(
residual_df: pd.DataFrame,
) -> float:
"""Compute chi2 value for a single residual table."""
return (np.array(residual_df[RESIDUAL]) ** 2).sum()
return float((np.array(residual_df[RESIDUAL]) ** 2).sum())


def calculate_llh(
Expand Down Expand Up @@ -362,7 +362,7 @@ def calculate_llh(
measurement_df, simulation_df, observable_df, parameter_df
)
llhs.append(_llh)
return sum(llhs)
return float(sum(llhs))


def calculate_llh_for_table(
Expand Down Expand Up @@ -423,7 +423,7 @@ def calculate_llh_for_table(
measurement, simulation, obs_scale, noise_distr, noise_value
)
llhs.append(llh)
return sum(llhs)
return float(sum(llhs))


def calculate_single_llh(
Expand Down