Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Mar 22, 2021

fixes various issues and enables fail-on-warning

@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #52 (8c0c864) into develop (1f7ade4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #52   +/-   ##
========================================
  Coverage    78.80%   78.80%           
========================================
  Files           24       24           
  Lines         2317     2317           
  Branches       548      548           
========================================
  Hits          1826     1826           
  Misses         359      359           
  Partials       132      132           
Impacted Files Coverage Δ
petab/lint.py 78.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f7ade4...8c0c864. Read the comment docs.

@dweindl dweindl changed the title Add .readthedocs.yaml Doc: Cleanup RTD config Mar 22, 2021
@dweindl dweindl requested a review from yannikschaelte March 22, 2021 15:59
Comment on lines 14 to 16
- requirements: .rtd_pip_reqs.txt
- method: pip
path: .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- requirements: .rtd_pip_reqs.txt
- method: pip
path: .
- method: pip
path: .
extra_requirements:
- doc

may be nicer

@@ -1,28 +0,0 @@
Editorial board
===============
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it gone?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see, it's only the library.

return True


def setup(app):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring

@dweindl dweindl merged commit eb893c6 into develop Mar 22, 2021
@dweindl dweindl deleted the doc branch March 22, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants