Conversation
Agent-Logs-Url: https://github.com/PFCCLab/dochooks/sessions/3a155e4a-477b-4883-9b33-26e81725a792 Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
SigureMo
April 25, 2026 17:34
View session
SigureMo
requested changes
Apr 25, 2026
| "pytest-rerunfailures>=16.0.1", | ||
| "tomli>=2.0.2; python_version < '3.11'", | ||
| "pre-commit>=4.3.0", | ||
| "ty>=0.0.32", |
Contributor
Author
There was a problem hiding this comment.
已调整，ty 已放回 dev 依赖列表最上面。commit: 5899c2b
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "python.languageServer": "None", | |||
Contributor
Author
There was a problem hiding this comment.
已去掉这行额外设置，workspace 配置恢复为原来的写法。commit: 5899c2b
Agent-Logs-Url: https://github.com/PFCCLab/dochooks/sessions/71884b6c-fbe0-465b-a4ca-cda8b2363dff Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>
SigureMo
approved these changes
Apr 25, 2026
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s Python type-checking workflow from Pyright to Astral’s ty, aligning developer tooling, CI/just recipes, and editor recommendations.
Changes:
- Replace
pyrightwithtyin dev dependencies and lockfile. - Update
just lintto runty check --error-on-warninginstead of Pyright. - Remove Pyright-specific configuration and let Ruff enforce
F401/F841again; update VS Code extension recommendations.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
uv.lock |
Drops pyright and adds ty to the locked dev dependency set. |
pyproject.toml |
Swaps dev dependency to ty, removes [tool.pyright], and stops ignoring Ruff F401/F841. |
justfile |
Updates the lint recipe to run ty check --error-on-warning. |
.vscode/extensions.json |
Replaces Pylance recommendation with the ty extension. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.toml