Conversation
Agent-Logs-Url: https://github.com/ShigureLab/expr-simplifier/sessions/bbbf3ae0-179b-40ad-9694-e6a3a440f32a Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ShigureLab/expr-simplifier/sessions/bbbf3ae0-179b-40ad-9694-e6a3a440f32a Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>
| passes: list[Pass], | ||
| description: str, | ||
| subparser: argparse._SubParsersAction[argparse.ArgumentParser], # pyright: ignore [reportPrivateUsage] | ||
| subparser: Any, |
Agent-Logs-Url: https://github.com/ShigureLab/expr-simplifier/sessions/8d74859a-e701-4f8a-97bc-3e7d404c7baa Co-authored-by: SigureMo <38436475+SigureMo@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Migrates the project’s type-checking tooling from Pyright to ty, updating dev dependencies and editor/lint workflow accordingly.
Changes:
- Replaced
pyrightwithtyinpyproject.tomlanduv.lock. - Updated
just lintto runty check(with--error-on-warning) and removed Pyright-specific VS Code settings/recommendations. - Adjusted typing in
src/expr_simplifier/__main__.pyto avoid reliance onargparseprivate types.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Removes pyright/nodeenv and adds locked ty distribution artifacts. |
src/expr_simplifier/__main__.py |
Introduces a Protocol to type add_parser without referencing private argparse types. |
pyproject.toml |
Swaps dev dependency pyright → ty and removes [tool.pyright] configuration. |
justfile |
Updates lint command to use uv run ty check --error-on-warning. |
.vscode/settings.json |
Removes Pyright/Pylance strict type-checking mode setting. |
.vscode/extensions.json |
Recommends the ty VS Code extension instead of Pylance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "recommendations": [ | |||
| "ms-python.python", | |||
There was a problem hiding this comment.
.vscode/settings.json still contains python.analysis.* settings (inlay hints), which are provided by Pylance. Since this change replaces the Pylance recommendation with astral-sh.ty, contributors may lose those editor features unless they manually install Pylance. Consider recommending both ms-python.vscode-pylance and astral-sh.ty, or remove the remaining python.analysis.* settings if the project is intentionally moving away from Pylance.
| "ms-python.python", | |
| "ms-python.python", | |
| "ms-python.vscode-pylance", |
Summary
pyrightwithtyin the dev dependency set and lockfiletytyValidation
uv run ty check --error-on-warning src/expr_simplifier testsuv run ruff check .uv run pytest --reruns 3 --reruns-delay 1uv buildReferences