feat: MACE logging - #257
Closed
FelyCZ wants to merge 5 commits into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dh-mace #257 +/- ##
========================================
Coverage 84.02% 84.02%
========================================
Files 49 49
Lines 6787 6787
Branches 786 786
========================================
Hits 5703 5703
Misses 878 878
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
@FelyCZ sorry, this has been closed accidentally when I merged the dh-mace branch to main. Can you please open a new PR against the main branch? I am not able to re-open this. |
danielhollas
reviewed
Aug 9, 2026
|
|
||
| After installation, run the MACE tests to make sure the basic communication works. | ||
| ```console | ||
| ```bash |
Contributor
There was a problem hiding this comment.
This one should be kept as console because it contains the command outputs as well
danielhollas
reviewed
Aug 9, 2026
| setup_logger(debug=False) | ||
| model = config.model_path | ||
| if not model.startswith("__MOCK_") and not Path(model).is_file(): | ||
| sys.exit(f"ERROR: file '{config.model_path}' not found") |
Contributor
There was a problem hiding this comment.
I'd prefer to keep this as is was so that the error message always gets printed regardless of logging configuration. But I don't feel strongly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the standard use of 'print' with a correctly configured 'logging' module.
It also introduces a dump of the environment information (for debugging purposes).
--
related to #242