Skip "optional before required" test for PHP >= 8.1. #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
Thanks 🎉 |
serge-kvashnin
deleted the
php-8.1-deprecated-optional-before-required
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 8.1 optional parameters before required are deprecated. Therefore in
DefaultValueResolver::getParameters()method a call to the reflection parameter$parameter->isDefaultValueAvailable()will always return false, even if the default value is there, when optional parameter is placed before required. So it'll always throw exception of missing parameter when test is running on PHP >= 8.1. I marked it as skipped for now, but I guess later it can be removed, because this behavior won't be supported.