Skip to content

Skip "optional before required" test for PHP >= 8.1. #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Skip "optional before required" test for PHP >= 8.1. #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/InvokerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,16 @@ public function should_invoke_callable_with_null_for_non_optional_nullable_param

/**
* @see https://github.com/PHP-DI/PHP-DI/issues/562
* @deprecated
* @test
*/
public function should_invoke_callable_with_optional_parameter_before_required_parameter()
{
if (version_compare(PHP_VERSION, '8.1') >= 0) {
/** @see https://www.php.net/manual/en/migration81.incompatible.php#migration81.incompatible.core.optional-before-required */
$this->markTestSkipped('An optional parameter specified before required parameters is now always treated as required.');
}

$result = $this->invoker->call(function ($baz = 'abc', $foo) {
return [$baz, $foo];
}, [
Expand Down