Tests: run against the *new* PHPCS 4 branch #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredden
approved these changes
May 15, 2025
The PHP_CodeSniffer 4.0 branch has been completely rebuild. See PHPCSStandards/PHP_CodeSniffer#120 for more detailed information about the "why". In practice, this means that to test against the upcoming PHPCS 4.0 release, we need to test against the `4.x` branch now, not the old `4.0` branch. A 4.0 beta/RC release is expected in the next few days. Once that is out, a test period starts and depending on whether problems are found or not, the 4.0.0 release will be tagged about a month later (or later if significant problems were found). When 4.0.0 gets tagged, the PHPCS `master` branch will be renamed to `3.x` and the `4.x` branch will be the new "main" branch for PHPCS, so more changes will be needed, but that's for later. Includes updating to the `DemoSniff` test fixture setup as PHPCS 4.0 will start enforcing for sniffs to implement the `Sniff` interface.
jrfnl
force-pushed
the
feature/ghactions-test-against-new-phpcs-4-branch
branch
from
6dbfafa to
c368238
Compare
fredden
approved these changes
May 15, 2025
Potherca
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The PHP_CodeSniffer 4.0 branch has been completely rebuild. See PHPCSStandards/PHP_CodeSniffer#120 for more detailed information about the "why".
In practice, this means that to test against the upcoming PHPCS 4.0 release, we need to test against the
4.xbranch now, not the old4.0branch.A 4.0 beta/RC release is expected in the next few days. Once that is out, a test period starts and depending on whether problems are found or not, the 4.0.0 release will be tagged about a month later (or later if significant problems were found).
When 4.0.0 gets tagged, the PHPCS
masterbranch will be renamed to3.xand the4.xbranch will be the new "main" branch for PHPCS, so more changes will be needed, but that's for later.Includes updating the
DemoSnifftest fixture setup as PHPCS 4.0 will start enforcing for sniffs to implement theSniffinterface.