NewConstantScalarExpressions: improve and expand tests (modern PHP)#1463
Merged
NewConstantScalarExpressions: improve and expand tests (modern PHP)#1463
Conversation
PHPCS contains a token array listing all the magic constants since PHPCS 3.5.6.
... to cover previously uncovered code paths.
Use the PHPCSUtils `Arrays::getDoubleArrowPtr()` method to retrieve the stack pointer to the applicable double arrow for the current array item. This should improve efficiency and reliability.
... to safeguard this is handled correctly.
... to safeguard these are handled correctly.
…aits ... to safeguard these are handled correctly.
jrfnl
added
Type: chores/QA
PR: quick merge
wimg
approved these changes
Jan 8, 2023
github-actions
bot
removed
PR: ready for review
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewConstantScalarExpressions: minor code simplification
PHPCS contains a token array listing all the magic constants since PHPCS 3.5.6.
NewConstantScalarExpressions: add some additional tests
... to cover previously uncovered code paths.
NewConstantScalarExpressions: code simplification using PHPCSUtils
Use the PHPCSUtils
Arrays::getDoubleArrowPtr()method to retrieve the stack pointer to the applicable double arrow for the current array item.This should improve efficiency and reliability.
NewConstantScalarExpressions: add test with PHP 7.4+ arrow function
... to safeguard this is handled correctly.
NewConstantScalarExpressions: add tests with constant in PHP 8.1+ enum
... to safeguard these are handled correctly.
NewConstantScalarExpressions: add tests with PHP 8.2+ constants in traits
... to safeguard these are handled correctly.