Conversation
…n names in combination with typed constants PHP 8.3 introduced typed constants. While the types themselves should not lead to false positives as the PHP native types are considered "other reserved keywords" and can be used as (class) constant names, so wouldn't be flagged, the sniff as-was would not find the _actual_ name of the constant for typed constants, which could result in false negatives. Fixed now. Includes tests. Ref: * https://www.php.net/manual/en/reserved.other-reserved-words.php
jrfnl
added
Type: enhancement
PR: quick merge
wimg
approved these changes
Aug 13, 2025
wimg
deleted the
php-8.3/forbiddennames-add-support-for-typed-constants
branch
github-actions
bot
removed
PR: ready for review
PR: quick merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.3 introduced typed constants.
While the types themselves should not lead to false positives as the PHP native types are considered "other reserved keywords" and can be used as (class) constant names, so wouldn't be flagged, the sniff as-was would not find the actual name of the constant for typed constants, which could result in false negatives.
Fixed now.
Includes tests.
Ref: