Skip to content

Conversation

@oleibman
Copy link
Collaborator

Also clean up the code a bit as long as I was in there.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Also clean up the code a bit as long as I was in there.
@oleibman
Copy link
Collaborator Author

oleibman commented Nov 26, 2025

One of the problems with Coveralls. The only module which I changed was 100% covered before, and still is. But I reduced the number of relevant lines from 31 to 27, so overall coverage was consequently reduced by a minuscule amount. C'est la vie.

@oleibman oleibman added this pull request to the merge queue Nov 26, 2025
Merged via the queue into PHPOffice:master with commit 097bea5 Nov 26, 2025
14 of 15 checks passed
@oleibman oleibman deleted the xmltodo branch November 26, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant