Skip to content

Conversation

@oleibman
Copy link
Collaborator

@oleibman oleibman commented Dec 8, 2025

The tests stay; they just no longer run in separate processes. I think that only 2 tests still require separate processes - Helper/SampleTest and Tcpdf/NoDieTest. Aside from a new internal method in IOFactory, all the changes here are to test members.

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • streamlining unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

The tests stay; they just no longer run in separate processes. I think that only 2 tests still require separate processes - Helper/SampleTest and Tcpdf/NoDieTest. Aside from a new internal method in IOFactory, all the changes here are to test members.
@oleibman oleibman added this pull request to the merge queue Dec 9, 2025
Merged via the queue into PHPOffice:master with commit 60aa970 Dec 9, 2025
15 checks passed
@oleibman oleibman deleted the unseparate branch December 9, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant