fix: stop classifying mixed as scalar - #210
Merged
Merged
Conversation
calebdw
force-pushed
the
calebdw/push-qywsktylpzlm
branch
from
July 9, 2026 13:44
d52dfd7 to
59fd673
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
calebdw
force-pushed
the
calebdw/push-qywsktylpzlm
branch
from
July 9, 2026 14:47
59fd673 to
66ba190
Compare
calebdw
changed the title
calebdw
force-pushed
the
calebdw/push-qywsktylpzlm
branch
from
July 9, 2026 15:00
66ba190 to
19e5284
Compare
calebdw
force-pushed
the
calebdw/push-qywsktylpzlm
branch
from
July 9, 2026 15:04
19e5284 to
b5dfb65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_scalar_name() incorrectly treated mixed as a scalar. That leaked into extract_value_type(skip_scalar=true), where array accesses on array<string, mixed> dropped the element type entirely. As a result, expressions like true ? $body['key'] : null resolved to null instead of mixed|null, producing false type_mismatch_argument diagnostics.
This PR fixes the root cause by stopping mixed from being classified as scalar, rather than special-casing the extractor. Because that change also affected unknown-member diagnostics, the resolver now keeps mixed in the "untyped / cannot verify" bucket there instead of treating it like an unloadable class name.
Fixes #206