Skip to content

feat(symfony): add forms, validation, and config schema intelligence - #404

Open
sidux wants to merge 30 commits into
PHPantom-dev:mainfrom
sidux:feat/symfony-forms-validation-config-intelligence
Open

feat(symfony): add forms, validation, and config schema intelligence#404
sidux wants to merge 30 commits into
PHPantom-dev:mainfrom
sidux:feat/symfony-forms-validation-config-intelligence

Conversation

@sidux

@sidux sidux commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • connect Symfony form field names to properties on their configured data classes
  • navigate validation properties and constraint classes from YAML and XML mappings
  • derive application configuration keys from local TreeBuilder schemas
  • provide navigation, completion, references, rename, diagnostics, and feature-scoped CodeLens for those symbols
  • index form and validation property references by class and member for fast CodeLens and reference lookup

Why

Form fields, validation mappings, and bundle configuration keys are real symbols even though Symfony stores many of them as strings outside normal PHP syntax. Deriving their meaning from data-class declarations and local configuration trees keeps the behavior framework-aware without hardcoding application conventions. Keeping the reverse property index with this feature also prevents its CodeLens from rescanning every resource file for every property.

Dependencies

Validation

  • focused forms, validation, configuration-schema, and incremental property-index tests
  • cargo clippy --fix --allow-dirty -- -D warnings
  • cargo fmt
  • cargo clippy --all-targets -- -D warnings
  • cargo test — 14,170 passed, 12 ignored

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 88.90278% with 710 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/code_lens.rs 88.14% 131 Missing ⚠️
src/completion/symfony.rs 85.43% 105 Missing ⚠️
src/symfony/container.rs 74.69% 104 Missing ⚠️
src/rename/prepare.rs 55.78% 65 Missing ⚠️
src/indexing/watch.rs 47.78% 59 Missing ⚠️
src/symfony/events.rs 93.90% 50 Missing ⚠️
src/symfony/expressions.rs 93.00% 45 Missing ⚠️
src/references/dispatch.rs 66.29% 30 Missing ⚠️
src/proxy_metadata.rs 92.13% 25 Missing ⚠️
src/references/members.rs 94.19% 25 Missing ⚠️
... and 10 more

📢 Thoughts on this report? Let us know!

@AJenbo AJenbo added this to the Sprint 8 milestone Aug 27, 2026
@sidux sidux mentioned this pull request Aug 27, 2026
6 tasks
sidux added 7 commits August 30, 2026 17:12
Use the coarse reference index for conclusive zero counts and cache bounded exact member locations for non-zero lenses. Refresh-capable clients avoid eager resolve storms while older clients retain lazy resolution.
Stop reference counts and CodeLens resolves from repeating the full workspace walk for every declaration. Internal annotation requests share the initial index, including callers queued behind it, while an explicit Find References command keeps its single refresh for files created without watcher notifications.
@sidux
sidux force-pushed the feat/symfony-forms-validation-config-intelligence branch from 408d7c0 to 834344c Compare August 30, 2026 15:33
sidux added 18 commits August 30, 2026 17:40
Resolve fully-qualified classes and Class::member references from arbitrary YAML and XML positions without schema-specific rules.
Feed schema-free class and member occurrences into Find References and CodeLens, including transparent-proxy metadata aliases.
Index semantic framework relationships alongside generic YAML and XML class references.
Pass every indexed target to editor-native navigation and ignore empty PHP resource strings.
Generic YAML and XML navigation now returns early only when it resolves a PHP symbol. Otherwise the semantic Symfony resolver still handles aliases, form fields, validation mappings, and configuration keys.
Build entity-to-repository pairs alongside the framework resource index and update them per URI. CodeLens and reference lookups now read the derived index instead of reopening and rescanning every YAML/XML resource for each declaration.
Discover opt-in generated subclasses by path and marker interface, then canonicalize external metadata without changing PHP type resolution.
Reuse the existing definition and reference pipelines for standard incoming and outgoing call navigation.
@sidux
sidux force-pushed the feat/symfony-forms-validation-config-intelligence branch from 834344c to bc45de5 Compare August 30, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants