Address potential unsigned underflow in streaming decoder claim_bytes()#389
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1659 1659
=========================================
Hits 1659 1659 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PJK
force-pushed
the
fix-claim-bytes-underflow
branch
from
February 8, 2026 17:38
1fea050 to
422ae3e
Compare
PJK
changed the title
The subtraction `provided - result->read` is computed as size_t. If result->read were ever greater than provided, this would underflow to a huge value, bypassing the bounds check. Rewrite as `required + result->read > provided` to avoid the subtraction entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PJK
force-pushed
the
fix-claim-bytes-underflow
branch
from
February 8, 2026 17:41
422ae3e to
f415463
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claim_bytes()instreaming.ccomputesprovided - result->readassize_t, which would underflow ifresult->read > providedresult->readis only incremented on successful claims, but the invariant was implicitTest plan
🤖 Generated with Claude Code