Fix bugs and cleanup in example code#401
Merged
Merged
Conversation
- Fix scanf -> sscanf in streaming_array.c (was never parsing argv) - Add missing #include <stdio.h> in streaming_array.c - Fix memory leak in cbor_sequence.c (missing cbor_move on array push) - Add missing #include <stdlib.h> in readfile.c and streaming_parser.c - Free json_buffer and close file in cjson2cbor.c - Add missing cbor_decref in sort.c Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1663 1663
=========================================
Hits 1663 1663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scanf->sscanfinstreaming_array.c— the command-line argument was never actually parsedcbor_sequence.c— missingcbor_moveoncbor_array_pushcalls#include <stdio.h>instreaming_array.c#include <stdlib.h>inreadfile.candstreaming_parser.cjson_bufferand close file handle incjson2cbor.ccbor_decreffor array insort.cTest plan
🤖 Generated with Claude Code